oae / gnome-shell-pano

Next-gen Clipboard Manager for Gnome Shell
https://extensions.gnome.org/extension/5278/pano/
GNU General Public License v2.0
1.13k stars 59 forks source link

Emoji with skin tone is not recognized as emoji #300

Closed azzamsa closed 5 months ago

azzamsa commented 5 months ago

Description

Emoji with skin tone is not recognized as emoji

Problem Explanation

If you copy a regular emoji such as 🙏, it is recognized as emoji. But, it doesn't when you choose the same emoji with other skin tone such 🙏🏻

image

Expected Behavior

It should recognize both of them as emoji and display with the same size.

Reprodution

Steps To Reproduce

Steps to reproduce, if applicable:

  1. Copy https://emojipedia.org/folded-hands
  2. Copy https://emojipedia.org/folded-hands-light-skin-tone
  3. See the difference

Details

It happens with any application?

It happens only on one computer?

It happens only with some specific gnome configuration?

It happens only with some specific extension installed?

azzamsa commented 5 months ago

We need to handle the additional byte for the skin tone. Related issue: https://github.com/hrsh7th/cmp-emoji/issues/11

boerdereinar commented 5 months ago

Fixed in #280 by just marking any single grapheme cluster as an emoji item. Screenshot from 2024-06-21 20-06-38

azzamsa commented 5 months ago

Amazing work! Thank you. 🍜