oae / gnome-shell-pano

Next-gen Clipboard Manager for Gnome Shell
https://extensions.gnome.org/extension/5278/pano/
GNU General Public License v2.0
1.12k stars 60 forks source link

Gnome 47 support #315

Closed Edu4rdSHL closed 1 month ago

Edu4rdSHL commented 2 months ago

Is your feature request related to a problem? Please describe. As the title says, Gnome 47 support. The latest commit was intended to work on Gnome 46 (which never reached a stable version), but there's nothing regarding Gnome 47, afaik.

Describe the solution you'd like Having the extension with Gnome 47 support on EGO.

Describe alternatives you've considered At least some beta/rc release with the required changes (if needed) pointing to support Gnome 47.

Additional context The current beta release that aimed at Gnome 46 does work fine on Gnome 47 RC, but I'm not sure if there's anything else that's needed to do for it to have the extension with Gnome 47 support on EGO instead of having to build manually from beta/git.

Totto16 commented 1 month ago

I'll work on it soon 👍🏼

flerouwu commented 1 month ago

@Totto16 Just changing resources/metadata.json to add 47 as a supported version appears to work fine. Pano loads correctly and appears to be working correctly as it did before I updated. I haven't done extensive testing however.

diff --git a/resources/metadata.json b/resources/metadata.json
index aead2f6..66776fb 100644
--- a/resources/metadata.json
+++ b/resources/metadata.json
@@ -9,5 +9,5 @@
   },
   "settings-schema": "org.gnome.shell.extensions.pano",
   "url": "https://github.com/oae/gnome-shell-pano",
-  "shell-version": ["45", "46"]
+  "shell-version": ["45", "46", "47"]
 }
Edu4rdSHL commented 1 month ago

I have been finding these messages on the journal after a small system freeze:

Sep 25 10:08:39 SecHackLabs gnome-shell[2601]: [pano] [extension] extension is enabled
Sep 25 10:08:39 SecHackLabs gnome-shell[2601]: [pano] [pango] class names not found: hashbang
Sep 25 10:08:39 SecHackLabs gnome-shell[2601]: [pano] [pango] class names not found: hashbang
Totto16 commented 1 month ago

@Totto16 Just changing resources/metadata.json to add 47 as a supported version appears to work fine. Pano loads correctly and appears to be working correctly as it did before I updated. I haven't done extensive testing however.

diff --git a/resources/metadata.json b/resources/metadata.json
index aead2f6..66776fb 100644
--- a/resources/metadata.json
+++ b/resources/metadata.json
@@ -9,5 +9,5 @@
   },
   "settings-schema": "org.gnome.shell.extensions.pano",
   "url": "https://github.com/oae/gnome-shell-pano",
-  "shell-version": ["45", "46"]
+  "shell-version": ["45", "46", "47"]
 }

That seems promising, there are little changes, that may affect pano, but some are, I am looking into them and also test them extensively 👍🏼

Totto16 commented 1 month ago

class names not found:

That's only a color error for code highlighting, and only a warning, but that will be obsolete soon ™️ with #278

Totto16 commented 1 month ago

I added support for gnome 47 in #316. I also tested it extensively myself, but it would help, if you also test it, especially if you are not using fedora 41, but some other distro that already has gnome 47.

So to test it, either:

Totto16 commented 1 month ago

Reopened this, to eventually fix things, if there should be issues, which there really shouldn't be, but who knows 🤷🏼‍♂️

edubxb commented 1 month ago

Downloaded and testing it on Debian Testing (Trixie).

Thanks for all the hard work making this awesome extension. I can't live without it! 🤩

zsolt-donca commented 1 month ago

It works for me on Arch on Gnome 47 using the AUR package gnome-shell-extension-pano-git. I will report any issues that I encounter (none so far).

literon36 commented 1 month ago

Using the release zip on Gnome 47 has no issues on my Arch machine! Thank you so much for providing this great extension and the ongoing support! Also couldn't live without it <3

gokeeper commented 1 month ago

The alpha release file works on Arch / Gnome 47, so far no issues, thanks!

Totto16 commented 1 month ago

It seems as it works flawlessly 😄, so I'll close this issue