oaeproject / 3akai-ux

Open Academic Environment (OAE) Front-End
http://www.oaeproject.org
Educational Community License v2.0
134 stars 206 forks source link

Left hand nav sliding can be choppy #3403

Closed nicolaasmatthijs closed 10 years ago

nicolaasmatthijs commented 10 years ago

On iPhone, Left-nav open-and-close sliding is a little bit choppy. It's most visible on the activity page, where presumably you have lots of elements on the page.

Also, it looks like the contents inside of it tries to awkwardly resize itself. Maybe the animation can be treated more like a "slide" while clipping away its contents rather than a "shrink". That might also take care of the choppiness.

nicolaasmatthijs commented 10 years ago

See https://github.com/oaeproject/3akai-ux/pull/3178/files#r9040135 for additional notes

mrvisser commented 10 years ago

That link doesn't take me to the comment :( what were the notes @nicolaasmatthijs ?

mrvisser commented 10 years ago

Fixing the width of the oae-page container nor switching to using css3 transforms seems to resolve the iphone choppiness, the CSS3 transforms arguably makes it worse.

I'm afraid I'm out of ideas on optimizing this for handhelds. I will reassign to Bert's more experienced eyes before closing this, but I don't think I should put any more more time into it.

mrvisser commented 10 years ago

I've submit a PR here for what I had on this in case it is useful in further investigating CSS transforms: https://github.com/bp323/3akai-ux/pull/28

bertpareyn commented 10 years ago

Reassigning to @Coenego for investigation.

Coenego commented 10 years ago

Unfortunately I didn't manage to find a solution for this issue. Tried some extra hacks that should improve the performance of the CSS transitions in the browser, but the choppy animations still remain... Reassigning to @bp323

timdegroote commented 10 years ago

Submitted a PR https://github.com/bp323/3akai-ux/pull/50 @bp323

bertpareyn commented 10 years ago

Tracked in https://github.com/oaeproject/3akai-ux/pull/3522