Ability to delete user - Githubissues

ClaireLozano commented 6 years ago

This is the front-end corresponding to the following pull request : https://github.com/oaeproject/Hilary/pull/1416 .

This change is

brecke commented 6 years ago

Check the comments. My overall notes are:

let's protect the delete archive user on the backend
let's make sure the archive user is created with confirmed email

both of these are backend related --'

Reviewed 4 of 4 files at r1. Review status: all files reviewed, 7 unresolved discussions (waiting on @ClaireLozano)

node_modules/oae-admin/manageuser/manageuser.html, line 244 at r1 (raw file):

        </button>
    {/if}
    {if !userProfile.isUserArchive}

let's not forget that just because we are removing this interface, we still need to prevent this from happening on the API side of things... I don't care much about the other actions, but this one is important

shared/oae/bundles/email/default.properties, line 15 at r1 (raw file):

ACTIVITY_EMAIL_SUMMARY_IMMEDIATE_SINGLE_ACTOR_SINGLE_ACTIVITY = ${actorLink} has been active recently
ACTIVITY_EMAIL_SUMMARY_WEEKLY = Here's what happened in the last week
EMAIL_DELETED_RESOURCE_BODY = This/these resource(s) will be deleted :

why space before :?

shared/oae/bundles/email/default.properties, line 16 at r1 (raw file):

ACTIVITY_EMAIL_SUMMARY_WEEKLY = Here's what happened in the last week
EMAIL_DELETED_RESOURCE_BODY = This/these resource(s) will be deleted : 
EMAIL_DELETED_RESOURCE_BODY_EXPLANATION = For now you can continue to access to this/these resource(s) but in ${nbMonth} month(s), the resource will definitively be removed from OAE. If you want to become manager of one of this resource(s), please contact the admin at the following email address : ${archiveEmail}.

...for now you may continue... ...removed from the system. ...manager of this/these resource(s),

again, why the space before :?

shared/oae/bundles/email/default.properties, line 17 at r1 (raw file):

EMAIL_DELETED_RESOURCE_BODY = This/these resource(s) will be deleted : 
EMAIL_DELETED_RESOURCE_BODY_EXPLANATION = For now you can continue to access to this/these resource(s) but in ${nbMonth} month(s), the resource will definitively be removed from OAE. If you want to become manager of one of this resource(s), please contact the admin at the following email address : ${archiveEmail}. 
EMAIL_LEFT_RESOURCE_BODY = This user has left the resource(s) :

here : as : well : )

shared/oae/bundles/email/default.properties, line 18 at r1 (raw file):

EMAIL_DELETED_RESOURCE_BODY_EXPLANATION = For now you can continue to access to this/these resource(s) but in ${nbMonth} month(s), the resource will definitively be removed from OAE. If you want to become manager of one of this resource(s), please contact the admin at the following email address : ${archiveEmail}. 
EMAIL_LEFT_RESOURCE_BODY = This user has left the resource(s) : 
EMAIL_SHARING_RESOURCE_BODY_EXPLANATION = ${userDeletedName} has deleted his account and you're actually sharing resource(s) together.

remove the actually.. maybe put it in the past too: USER has deleted his account and you have been sharing resources together.

shared/oae/bundles/email/default.properties, line 23 at r1 (raw file):

EMAIL_VERIFY_SUBJECT = Please verify your email address
EMAIL_VERIFY_VERIFY_MY_EMAIL = Verify my email
USER_REMOVED_SUBJECT = A user has left oae

has left the system.

shared/oae/bundles/email/fr_FR.properties, line 16 at r1 (raw file):

ACTIVITY_EMAIL_SUMMARY_IMMEDIATE_SINGLE_ACTOR_SINGLE_ACTIVITY=${actorLink} a \u00e9t\u00e9 actif/active r\u00e9cemment
ACTIVITY_EMAIL_SUMMARY_WEEKLY=Voici ce qui s'est pass\u00e9 la semaine derni\u00e8re
EMAIL_DELETED_RESOURCE_BODY=Ces ressources seront supprim\u00e9es :

same here and all the ones below : ok? : )

Comments from Reviewable

brecke commented 5 years ago

Closing. See https://github.com/oaeproject/3akai-ux/pull/4224 for more information

oaeproject / 3akai-ux

Ability to delete user #4188