search

oaeproject / 3akai-ux

Open Academic Environment (OAE) Front-End
http://www.oaeproject.org
Educational Community License v2.0
134 stars 206 forks source link

Fixes #4199 #4200

Closed brecke closed 6 years ago

brecke commented 6 years ago

Requirejs optimize no longer uglifies Now using uglify-es and grunt-contrib-uglify-es instead of requirejs

brecke commented 6 years ago

we still have

'fileExclusionRegExp': /^(\.|<%= target %>|tests|tools|grunt|optimist|properties-parser|readdirp|underscore$|shelljs$|oae-release-tools|benchmark|robots\.txt)/,

where I'd try and remove these grunt|optimist|properties-parser|readdirp|underscore$|shelljs$|oae-release-tools|benchmark but I'm not sure that's a good idea. I just removed the ones that have been added during 2017 ±, I think I'll leave the others for another time, do you agree?

sallakarppinen commented 6 years ago

Yeah, agreed. Grunt, optimist, oae-release-tools etc won't be used while the app is running anyway. The only one we might have any benefit from is underscore, and even then it probably won't matter that much.