search

oaeproject / puppet-hilary

Open Academic Environment (OAE) Puppet Scripts
http://www.oaeproject.org
5 stars 20 forks source link

First attempt at puppet conf changes #242

Closed sallakarppinen closed 7 years ago

sallakarppinen commented 7 years ago

UNFINISHED DO NOT MERGE - I'm a bit uncertain about syntax in a couple of places, but this should give some indication of where I'm going with this.

davidoae commented 7 years ago

Each section within the 'file' meta-section is effectively completely separate so yes a 'require' is likely needed.

On 25 August 2017 at 13:14, Salla Karppinen notifications@github.com wrote:

@sallakarppinen commented on this pull request.

In modules/hilary/manifests/init.pp https://github.com/oaeproject/puppet-hilary/pull/242#discussion_r135244474 :

Env specific config file

"${app_root_dir}/${environment}.js": ensure => present, mode => "0644", owner => $os_user, group => $os_group,

  • content => template('hilary/${environment}.js'),
  • require => [ File[$upload_files_dir], File[$config_files_tmp_dir], File[$config_files_tmp_upload_dir] ]
  • }
  • source => "puppet:///modules/hilary/${environment}.js";

Does the require need to be included in every statement or need to be in the last statement? I left in the original line require => [ File[$upload_files_dir], File[$config_files_tmp_dir], File[$config_files_tmp_upload_dir] ]; on line 149.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/oaeproject/puppet-hilary/pull/242#discussion_r135244474, or mute the thread https://github.com/notifications/unsubscribe-auth/AKc2L-LYd1YVNGp-cWz07-rDx7rQlofvks5sbrq-gaJpZM4PCiNM .

sallakarppinen commented 7 years ago

Cool - I've added it plus local.js file and missing brace.

sallakarppinen commented 7 years ago

Added braces around env.

sallakarppinen commented 7 years ago

Tested on qa and ready to be merged now, but also contains the node 6 changes which should probably be merged separately first.