search

oakes / Nightlight

An embedded editor for Clojure
https://sekao.net/nightlight/
The Unlicense
788 stars 35 forks source link

Fully-qualified keywords appear as "invalid" #44

Closed n2o closed 6 years ago

n2o commented 6 years ago

This issue is related to #2 , but this is a general problem with fully-qualified keywords. They are not correctly interpreted, which is a problem when writing clojure.specs or similar.

image

image

We tried to use nighlight on a server-installation of a prototype, but all specs are wrongly interpreted in the Web UI, which disturbs the workflow, because everything appears with a red failure-icon.

mattiasw2 commented 6 years ago

Same problem with (s/def ::aws-access-key-id string?)

oakes commented 6 years ago

I finally fixed this issue, and I'll be making a new release today.

oakes commented 6 years ago

I have released nightlight 1.9.0 which fixes this issue.

ioRekz commented 6 years ago

Hi, I think this is a related error screen shot 2017-12-29 at 15 11 41

events is required as [nightcoders.events :refer [<sub] :as events])

the whole project is on nightcoders : http://nightcoders.net/1469/1852/code/ file : form.cljs

oakes commented 6 years ago

Yeah I noticed this recently; it appears that keywords with aliases still show up as an error. The workaround is to write :nightcoders.events/log like you do on the line below. I'll re-open this issue and look into it soon.

oakes commented 6 years ago

@ioRekz I just released Nightlight 2.1.0 which fixes the remaining aliased keyword issue. I also updated Nightcoders.net with the same fix. Thanks!

ioRekz commented 6 years ago

Thanks for the quick fix !

Was there some recent changes with how parinfer works ? I feel like it's not closing/moving parens as it used to. Really not sure about it so you can ignore if you didn't notice anything.

oakes commented 6 years ago

Not that I know of but if you notice a specific thing that seems wrong feel free to make an issue