search

oakes / Nightweb

An anonymous P2P social network in Clojure
https://sekao.net/nightweb/
The Unlicense
497 stars 71 forks source link

Images support is broken #25

Closed indeyets closed 11 years ago

indeyets commented 11 years ago

Images get weirdly cut/scaled at times. For example, if I try to attach this file: https://gs1.wac.edgecastcdn.net/8019B6/data.tumblr.com/eb50190272c344f7d56e50aaff3beb10/tumblr_mqt1izNbYX1r0ykcvo1_500.png only the left part is showed in nightweb

oakes commented 11 years ago

Fixed in a34536a3dc0a30d2aee488542caa861a8abf015d, thanks.

indeyets commented 11 years ago

Did you try to do the test with mentioned file? Because your patch doesn't fix issue I'm talking about.

the problem happens on clojure/java side of things, not on js-side.

steps to reprodoce:

  1. attach the image
  2. look at full-size representation of image, which Nightweb created

p.s. regarding borwser-side issues: type=post page does CSS forced scaling of image into the square instead of cropping, but, again, that is not the problem I'm talking about

oakes commented 11 years ago

I did use the test image and it appears to work for me -- see screenshot. For the desktop version, the image resizing and cropping happens in JavaScript via the resizeImage function, which is what I edited. Is there a reason you think the problem is elsewhere?

indeyets commented 11 years ago

@oakes sorry. it was my local fluctuation. tested and confirmed :+1: