search

oakes / play-clj

A Clojure game library
The Unlicense
940 stars 72 forks source link

Fix for texture misalignment with relation to Box2D Shapes #98

Closed the2bears closed 8 years ago

the2bears commented 8 years ago

Textures should not have the extra translation currently provided with the origin-x and origin-y values. A regular ShapeEntity does not use this for rendering, nor should textures.

Additionally, textures and circle shapes do not treat their respective origins the same - a circle is in the middle, whereas the texture uses lower/left as its origin. This allows adding translate-x and translate-y keys into the entity map for textures to be aligned with their respective Box2D shape.

oakes commented 8 years ago

Hi, sorry for the delayed response. Do you still recommend this change, or would you prefer keeping it out since you closed the PR?

the2bears commented 8 years ago

Hi Zach,

Let me split the changes and submit another PR. The one change, re: not using origin-x and origin-y, has worked with a few different tests and I do still recommend it. The other change, re: the origin of a circle shape and how to get that to align with a texture requires some more thought.

Regards,

Bill

On Sun, Jul 10, 2016 at 7:27 PM, Zach Oakes notifications@github.com wrote:

Hi, sorry for the delayed response. Do you still recommend this change, or would you prefer keeping it out since you closed the PR?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/oakes/play-clj/pull/98#issuecomment-231629158, or mute the thread https://github.com/notifications/unsubscribe/AGOaORqr8PM-7hU6cgWSYpWMJxwaCty8ks5qUaongaJpZM4JEoiB .