search

oakmac / standard-clojure-style-js

Standard Clojure Style in JavaScript
ISC License
88 stars 2 forks source link

Formatting breaks the `:require` block! #166

Closed licht1stein closed 3 hours ago

licht1stein commented 1 day ago

This is a very serious issue for us, standard-clj doesn't seem to be handling the :rename form correctly.

It turns:

(ns hello
  (:require [other :refer :all :rename {foo bar}]))

into this:

(ns hello
  (:require
   [other :refer [bar foo]]))

Literally breaking the import and rendering the namespace unusable.

oakmac commented 1 day ago

Thank you for the report! Fixed with PR-167

oakmac commented 1 day ago

This fix is available with v0.17.0. Can you confirm that it works for your codebase @licht1stein ?

licht1stein commented 4 hours ago

Will check as soon as I have a chance, thanks for the quick fix!

licht1stein commented 3 hours ago

Seems to be fine with version 0.18.0, thank you!