search

oakmound / oak

A pure Go game engine
Apache License 2.0
1.53k stars 83 forks source link

fix StripOuterAlpha to actually be functional #150

Closed Implausiblyfun closed 3 years ago

Implausiblyfun commented 3 years ago

Creating this as a pull request as I am not sure it should be executed on.

Namely there existed an untested function that did not do what it stated and instead when used this filter would only ever fail and return an error or fail to update the image.

There is of course the possible argument that we should just remove the function entirely or not touch it as there could be existing consumers... but in my mind this is the right path.

codecov-io commented 3 years ago

Codecov Report

Merging #150 (6e665c4) into release/2.4.1 (05ad80b) will increase coverage by 0.36%. The diff coverage is 50.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/2.4.1     #150      +/-   ##
=================================================
+ Coverage          92.25%   92.62%   +0.36%     
=================================================
  Files                122      122              
  Lines               4173     4177       +4     
=================================================
+ Hits                3850     3869      +19     
+ Misses               290      269      -21     
- Partials              33       39       +6
Impacted Files Coverage Δ
render/mod/filter.go 90.17% <50.00%> (+17.03%) :arrow_up:
shape/condense.go 94.33% <0.00%> (-5.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05ad80b...6e665c4. Read the comment docs.