Closed 200sc closed 3 years ago
License issue resolved, it thought we brought in aws?
Other notes:
Its frustrating that if you have a single window open, help
does not present the commands for that window
Help commands on print out maybe should be line by line instead of all on one line? And we could provide usage text somehow? Maybe that's for a later push
// strToInt32 helps align to the window scope handles
func strToInt32(potentialInt string) (int32, error) {
i64, err := strconv.ParseInt(potentialInt, 10, 32)
return int32(i64), err
}
// parseTokenAsInt is a convience function for parsing from our string slice of strings
func parseTokenAsInt(tokenString []string, arrIndex int, defaultVal int) int {
if len(tokenString) > arrIndex {
tmp, err := strconv.Atoi(tokenString[arrIndex])
if err == nil {
return tmp
}
}
return defaultVal
}
I would drop these comments or move them to an internal utility parsing package, see the similar utilities we have in particle demo
Codecov Report
41.66% <0.00%> (-58.34%)
99.15% <0.00%> (+1.68%)
Continue to review full report at Codecov.