200sc commented 3 years ago

Hotfix immediately following release, as is mandatory.

Need to evaluate the problem more closely to ensure this fixes it-- but the caller map for non-default event buses did not line up with the caller map that was owned by the window itself. @Implausiblyfun

codecov-commenter commented 3 years ago

Codecov Report

Merging #165 (f777b0d) into master (314b923) will decrease coverage by 0.02%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   92.76%   92.74%   -0.03%     
==========================================
  Files         140      140              
  Lines        6291     6295       +4     
==========================================
+ Hits         5836     5838       +2     
- Misses        398      400       +2     
  Partials       57       57

Impacted Files	Coverage Δ
config.go	`100.00% <ø> (ø)`
dlog/default.go	`100.00% <ø> (ø)`
event/bus.go	`96.00% <0.00%> (-4.00%)`	:arrow_down:
event/handler.go	`96.66% <ø> (ø)`
mouse/mouse.go	`100.00% <ø> (ø)`
sceneLoop.go	`91.01% <100.00%> (+0.20%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 314b923...f777b0d. Read the comment docs.

200sc commented 2 years ago

OK, I'll refactor this to make it not a breaking change then merge.

oakmound / oak

event: add SetCallerMap to Bus and Handler #165

Codecov Report