oakmound / oak

A pure Go game engine
Apache License 2.0
1.52k stars 84 forks source link

Add experimental android support #188

Closed 200sc closed 2 years ago

200sc commented 2 years ago

I think we should merge this in after we add instructions for how to set this up, then cut a release with it + windows arm

codecov-commenter commented 2 years ago

Codecov Report

Merging #188 (ebf404b) into master (935dec0) will increase coverage by 0.07%. The diff coverage is 55.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   92.60%   92.67%   +0.07%     
==========================================
  Files         141      141              
  Lines        6406     6406              
==========================================
+ Hits         5932     5937       +5     
+ Misses        415      407       -8     
- Partials       59       62       +3     
Impacted Files Coverage Δ
window.go 66.95% <ø> (ø)
drawLoop.go 62.26% <52.63%> (+11.32%) :arrow_up:
lifecycle.go 72.05% <100.00%> (ø)
collision/rtree.go 97.90% <0.00%> (-1.40%) :arrow_down:
event/handler.go 96.66% <0.00%> (ø)
sceneLoop.go 94.38% <0.00%> (+3.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 935dec0...ebf404b. Read the comment docs.

200sc commented 2 years ago

After this is merged, we should open an issue that gomobile init requires a c compiler (although I don't know if we can do anything about it realistically, historically we still make this an issue)

I'll also open an issue that our driver does not respect when the android phone changes orientation.