search

oakmound / oak

A pure Go game engine
Apache License 2.0
1.52k stars 84 forks source link

event/internal: Unbind calls now take the current reset of the bus #208

Closed Implausiblyfun closed 2 years ago

Implausiblyfun commented 2 years ago

When returning unbindthisbind we previously did not take into account the bus reset count. Now we will succesfully remove the bind as long as the bus has not already been reset between the unbind call and unbind's go channel's resolution.

codecov-commenter commented 2 years ago

Codecov Report

Merging #208 (9e53a7e) into master (e4df7da) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         143      143           
  Lines        6344     6344           
=======================================
  Hits         6026     6026           
  Misses        287      287           
  Partials       31       31
Impacted Files Coverage Δ
event/internal.go 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

200sc commented 2 years ago

Will merge once all the runners have finished their tests and cut v4.0.1