search

oakstudios / joinmastodon

The official Mastodon project homepage
https://joinmastodon.org
0 stars 0 forks source link

added IconCard #14

Closed danielgamage closed 2 years ago

danielgamage commented 2 years ago

from Card+Icon component. named this IconCard, but i guess it could be CardAndIcon?

added some pre-typescript type comments but they don't work GR8. i couldn't get the 

@param {string} props.icon - description

syntax to surface any type info in the editor, it just made all the props any, but i'm probably doing something wrong...

fixes #8

mikabusante commented 2 years ago

ohhhhh you know what....I wonder if that syntax was only working in dropmark-next because we're using typescript on that project 🤔

I was looking at what other people do, and it seems that JSDocs is often used in conjunction with TS or prop-types such as https://www.inkoop.io/blog/a-guide-to-js-docs-for-react-js/

danielgamage commented 2 years ago

merging this for now—we might have another style of this

image

but we can come back to it