Closed danielgamage closed 2 years ago
anything left to do here?
from my limited understanding of how it should read, things are actually looking quite good
i thought about mirroring these icons (specifically feed), but i think since some of them represent physical objects or symbols (eg server rack, dollar sign), it would actually be very broken to flip all of them
also thought about making these explicitly LTR, but since the FREE/PAID text is localized, i think RTL makes sense.
does it need server-side localization props?
ur totatlly right, lemme push that rn
also i agree about keeping the icons as is!
cool we can close then 🏁
arabic in particular should have some RTL accommodations in the design to have parity with the existing site as we dev our components out
we have some opportunities to fix some RTL bugs, too:
there's rtl selectors in tailwind which might occasionally be helpful (conditional illustrations), but compared to using logical properties for the layout, this approach would make RTL feel like an afterthought
tailwindcss-logical seems better, giving us lower-level control of the properties used
compared to something like tailwindcss-vanilla-rtl which forces logical properties everywhere, having the ability to decide which design elements need to be re-aligned and where seems like a more appropriate and nuanced approach
opening this as an issue to keep this in mind and mark commits with it