oakstudios / joinmastodon

The official Mastodon project homepage
https://joinmastodon.org
0 stars 0 forks source link

Testimonial bugs + carousel? #72

Closed mikabusante closed 2 years ago

mikabusante commented 2 years ago

I can barely see rounded corners on testimonial avatars. It was also supposed to be a carousel originally, right?

We can increase the border radius to 4px (I think it's 2px right now). Also if we're going back to the carousel, could check out https://keen-slider.io/

mikabusante commented 2 years ago

unknown also this, but doesn't need to be fixed if we go with the carousel.

mikabusante commented 2 years ago

ok -- trying to add the carousel on this branch with keen-slider but it's pretty unstable :///

looks great with ltr languages but breaks entirely when switching to rtl.

https://user-images.githubusercontent.com/31963784/183095029-588deabc-b51d-4ac4-afd0-ea6bd5fa67ce.mp4

the slider has a rtl: true || false option but I can't seem to get it to work with either direction, so we couldn't even just keep it on LTR mode, it breaks either way.

Looks fine after a refresh, but since the locale change does not refresh the page, this isn't going to work.

mikabusante commented 2 years ago

@danielgamage do u have any ideas for this? This uses keen-slider, but last week with no success I also tried :

unless there's an option I haven't tried yet, can we just straight up nix the carousel since I can't seem to find a good solution that a) isn't a huge JS library, b) is stable for LTR and RTL, c) functions well.

Gargron commented 2 years ago

The carousel can go left to right on RTL languages too. I think the surrounding element just needs dir: ltr on it to make sure it stays the same way when whole page direction is changed.

mikabusante commented 2 years ago

ok good to know, I'll try that 👍