Setup.py Error

[GoogleCodeExporter]

The following two lines should be tuples as opposed to lists as shown in the 
diff:

Index: setup.py
===================================================================
--- setup.py    (revision 536)
+++ setup.py    (working copy)
@@ -493,9 +493,9 @@
     probes_d = os.path.join(V8_HOME, "src/probes.d")
     probes_h = os.path.join(V8_HOME, "src/probes.h")

-    if exec_cmd("dtrace -h -xnolibs -s %s -o %s" % [probes_d, probes_h]):
+    if exec_cmd("dtrace -h -xnolibs -s %s -o %s" % (probes_d, probes_h)):
         pass
-    elif exec_cmd("dtrace -h -C -s %s -o %s" % [probes_d, probes_h]):
+    elif exec_cmd("dtrace -h -C -s %s -o %s" % (probes_d, probes_h)):
         pass
     else:
         print("INFO: dtrace or systemtap doesn't works, force to disable probes")

Original issue reported on code.google.com by artlo...@gmail.com on 17 Sep 2013 at 10:36

[GoogleCodeExporter]

Furthermore, exec_cmd expects a message, but none is given.

Original comment by artlo...@gmail.com on 17 Sep 2013 at 10:43

[GoogleCodeExporter]

The following nearby line appears to be incorrect as well:

-        config_file = os.path.join(V8_HOME, "src/Config.h")
+        config_file = os.path.join(PYV8_HOME, "src/Config.h")

Original comment by artlo...@gmail.com on 17 Sep 2013 at 10:58

[GoogleCodeExporter]

Finally, I don't see probes.d or probes.h anywhere in the V8 source tree.

Original comment by artlo...@gmail.com on 18 Sep 2013 at 1:22

[GoogleCodeExporter]

Sorry, just submit a wrong setup.py version which is developing :)

Original comment by flier...@gmail.com on 18 Sep 2013 at 2:15

• Changed state: Accepted
• Added labels: OpSys-All

[GoogleCodeExporter]

Please verify the fix with SVN r537 or later, thanks

Original comment by flier...@gmail.com on 18 Sep 2013 at 3:12

[GoogleCodeExporter]

Original comment by flier...@gmail.com on 18 Sep 2013 at 3:13

• Changed state: Fixed

[GoogleCodeExporter]

Thanks!  This problem is resolved.

Original comment by artlo...@gmail.com on 18 Sep 2013 at 2:38