search

oalders / http-browserdetect

Determine the Web browser, version, and platform from an HTTP user agent string
http://www.browserdetect.org
Other
58 stars 47 forks source link

Samsung Browser for Android is detected as Chrome #191

Closed oschwald closed 3 years ago

oschwald commented 3 years ago

This browser appears to be a Blink-based browser that is similar but not the same as Chrome. Here is an example UA:

Mozilla/5.0 (Linux; Android 8.1.0; SAMSUNG SM-G610M) AppleWebKit/537.36 (    KHTML, like Gecko) SamsungBrowser/14.2 Chrome/87.0.4280.141 Mobile Safari/537.36

The browser string is currently "Chrome".

I also wonder if blink would make more sense as the engine, but that is orthogonal.

oalders commented 3 years ago

What should this ideally be returning for the browser? Chromium with blink as the engine?

Current output is https://www.browserdetect.org/?ua=Mozilla%2F5.0+%28Linux%3B+Android+8.1.0%3B+SAMSUNG+SM-G610M%29+AppleWebKit%2F537.36+%28++++KHTML%2C+like+Gecko%29+SamsungBrowser%2F14.2+Chrome%2F87.0.4280.141+Mobile+Safari%2F537.36

oalders commented 3 years ago

See also https://github.com/oalders/http-browserdetect/issues/164

oalders commented 3 years ago

So maybe SamsungBrowser?

oschwald commented 3 years ago

uasurfer for Go returns just Samsung. The description on Google Play seems to use "Samsung Internet Browser" and "Samsung Internet".

I think I'd expect the browser to be pretty specific, e.g., "Samsung", rather than "Chromium". For engine, I'd expect all of the Chromium-based browsers, e.g., Chrome, Opera, Edge, this one, to have blink as the engine.

oschwald commented 3 years ago

That said, I haven't looked closely at what this module does for some of the other less common Chromium browsers, e.g., Vivaldi, Brave, Amazon Silk, etc.