search

oam-dev / oam-dev.github.io

OAM website: https://oam.dev
https://oam-dev.github.io/
MIT License
20 stars 18 forks source link

Install Netlify GitHub App for PR preview #19

Open tomkerkhove opened 4 years ago

tomkerkhove commented 4 years ago

I've noticed Netlify is being used for hosting the content based on https://github.com/oam-dev/oam-dev.github.io/blob/dev/netlify.toml

The Netlify GitHub App could be use to build a preview of the website in a PR so that it can be reviewed as it would be deployed.

For an example, see https://github.com/tomkerkhove/promitor/pull/766 which generated https://deploy-preview-766--promitor-staging.netlify.com/. I'm not using Netlify for my PROD site so it would be https://deploy-preview-766--oam.netlify.com/.

flynnduism commented 4 years ago

The site used Netlify for earlier dev and staging work, but the live site is actually hosted on Github Pages.

live site     -->   oam-dev.github.io
staging site  -->   oamdev.netlify.com

I'd prefer to use Netlify as well as their continuous deployment for Hugo static sites is smoother than Github Pages. Currently we have to run these steps to deploy. Plus the deploy previews you mention on pull requests is a great feature.

@vturecek what do you think? What we have right now works. Changing would require a DNS edit.