oam-dev / rudr

A Kubernetes implementation of the Open Application Model specification
https://oam.dev
MIT License
1.54k stars 136 forks source link

Support Logging Trait #174

Open wonderflow opened 5 years ago

wonderflow commented 5 years ago

When we discussed with our cloud team, they suggest we should give logging trait support, for users to query the log in containers.

When user add this logging trait, we can send their logs to logging system such as Elasticsearch.

LucioFranco commented 5 years ago

Hi all! I work at @timberio and we have https://github.com/timberio/vector I am curious to know what possibilities there might be to integrate vector as a logging trait with rudr? I am still learning my way around the whole kube world so this may be the wrong place to ask 😄

suhuruli commented 5 years ago

@LucioFranco , this is a fine place to bring this up! We are all learning btw :)

I'm wondering if you can bring this up in the community call we will be having next week and then we can go from there. At first glance, this sounds like a great place for integration!

LucioFranco commented 5 years ago

@suhuruli Sure! I will attempt to attend next weeks call! Thanks.

wonderflow commented 4 years ago

This is a gentle ping, do you need some help for logging trait implementation? @LucioFranco

LucioFranco commented 4 years ago

@wonderflow hi! I have not had a chance to make the meeting and went on vacation so was a bit silent.

I'd love to know more what you all are thinking around this logging trait?

wonderflow commented 4 years ago

@LucioFranco I think supporting collecting logs for container stdout for the first version of logging trait is enough.

We're planning the next release of rudr, just kindly ask when could you give implementation for it?

LucioFranco commented 4 years ago

I have not dug too deep yet, but looking at capturing stdout, does this just mean connecting to containers directly, or using the kube logging files and collecting them as a daemonset. Also am curious how you might see a product like vector used here.

wonderflow commented 4 years ago

does this just mean connecting to containers directly, or using the kube logging files and collecting them as a daemonset.

Both of them works, but the trait is binding to the component, so when we specify a logging trait to a component, we only need to collect the containers created by the component.

Using vector is fine.

LucioFranco commented 4 years ago

Sounds good! We should be landing kube support very soon, I will wait until that is in a release and ill at tackling this if no one else has! Thanks for the info.