[RHELC-1583] Check if rollback failed when handling InhibitorFound exception

hosekadam commented 5 months ago

When InhibitorFound exception is raised, check if rollback was successful is needed. This will affect the result return code:

1 - rollback fail
2 - inhibitor

Jira Issues:

RHELC-1583

Checklist

[ ] PR has been tested manually in a VM (either author or reviewer)
[ ] Jira issue has been made public if possible
[ ] [RHELC-] is part of the PR title
[ ] GitHub label has been added to help with Release notes
[ ] PR title explains the change from the user's point of view
[ ] Code and tests are documented properly
[ ] The commits are squashed to as few commits as possible (without losing data)
[ ] When merged: Jira issue has been updated to Release Pending if relevant

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.42%. Comparing base (63caca2) to head (c6d47dc). Report is 4 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1224 +/- ## ======================================= Coverage 95.42% 95.42% ======================================= Files 54 54 Lines 4699 4703 +4 Branches 829 830 +1 ======================================= + Hits 4484 4488 +4 Misses 132 132 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1224/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `90.64% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.56% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.61% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kokesak commented 5 months ago

Proper verification will be done under the https://github.com/oamg/convert2rhel/pull/1206. I tried manually running the test on Alma8.8 and the convert method now also returns 1 when rollback hits an issue. Also tried running tests jobs via tesar but the TF is a bit unreliable:

has-bot commented 5 months ago

This PR does not require integration tests to be run.

Comment generated by an automation.

Log | Bot Usage

r0x0d commented 5 months ago

Proper verification will be done under the #1206. I tried manually running the test on Alma8.8 and the convert method now also returns 1 when rollback hits an issue. Also tried running tests jobs via tesar but the TF is a bit unreliable:
* C7 http://artifacts.osci.redhat.com/testing-farm/f9b0e829-2658-480b-9a0d-10e695b3a022

* C8 http://artifacts.osci.redhat.com/testing-farm/66ef01a1-bd1a-4f30-a9a9-0e9043253598

* OL7 http://artifacts.osci.redhat.com/testing-farm/04b51ead-d327-4611-8e41-c8e32ba0b8fe

* OL8 http://artifacts.osci.redhat.com/testing-farm/27604cfc-9e2b-46df-8dbd-bfe723d18d12

* AL8 http://artifacts.osci.redhat.com/testing-farm/25a35911-3b40-4007-8a73-8a5243290719

* ROC8 http://artifacts.osci.redhat.com/testing-farm/59b33c71-6baf-4217-99c4-1316c83fdb44

Can we merge this then?

oamg / convert2rhel

[RHELC-1583] Check if rollback failed when handling InhibitorFound exception #1224

Codecov Report