oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
104 stars 83 forks source link

[RHELC-1554] Fix ELS repositories not fallback in case of error #1229

Closed r0x0d closed 3 months ago

r0x0d commented 3 months ago

We want to try to enable the ELS repos, and if case that fails, we want to make sure we enable the default rhel repoids.

Jira Issues:

Checklist

has-bot commented 3 months ago

/packit test --labels tier0


Comment generated by an automation.

Log | Bot Usage
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.42%. Comparing base (5ba85ef) to head (3dbcc26).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1229 +/- ## ======================================= Coverage 95.42% 95.42% ======================================= Files 54 54 Lines 4698 4699 +1 Branches 829 829 ======================================= + Hits 4483 4484 +1 Misses 132 132 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1229/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1229/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `90.63% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1229/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.55% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1229/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.61% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

r0x0d commented 3 months ago

/packit test --labels tier0

bookwar commented 3 months ago

As discussed in the ticket, rather than adding fallback for ELS repositories, let's remove fallback for EUS too.

As ELS and EUS repositories are now requested explicitly via command line switch, the proper fallback is for a user to remove the incorrect cli option. We should not try to do this implicitly during the conversion.

r0x0d commented 3 months ago

Alright, will open a PR for that in a minute.