[RHELC-1291, RHELC-1292] Skip versionlock file in backup system actions

bookwar commented 3 months ago

Versionlock file has been backed up and cleared before we run the backup action via a prepare_system() call in main.py, thus we should exclude it, so that we do not overwrite it with empty data.

Jira Issues:

Checklist

[ ] PR has been tested manually in a VM (either author or reviewer)
[ ] Jira issue has been made public if possible
[x] [RHELC-] is part of the PR title
[ ] GitHub label has been added to help with Release notes
[ ] PR title explains the change from the user's point of view
[ ] Code and tests are documented properly
[ ] The commits are squashed to as few commits as possible (without losing data)
[ ] When merged: Jira issue has been updated to Release Pending if relevant

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.42%. Comparing base (bd8abf9) to head (08c9bad). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1233 +/- ## ======================================= Coverage 95.42% 95.42% ======================================= Files 54 54 Lines 4702 4703 +1 Branches 830 830 ======================================= + Hits 4487 4488 +1 Misses 132 132 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1233/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1233/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `90.64% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1233/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.56% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1233/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.61% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 3 months ago

/packit test --labels tier1

Comment generated by an automation.

Log | Bot Usage

danmyway commented 3 months ago

/packit test --labels tier1

danmyway commented 3 months ago

/packit test --labels tier1

hosekadam commented 3 months ago

Just if you want, you can add ("S.5....T. c /etc/yum/pluginconf.d/versionlock.list", "File {filepath} already backed up - not backing up again"), as new test here: https://github.com/oamg/convert2rhel/blob/main/convert2rhel/unit_tests/actions/pre_ponr_changes/backup_system_test.py#L253 It might prevent us from accidentally removing it from the skip list

danmyway commented 3 months ago

Please run /packit test --labels tier1 whenever the PR is ready to be tested.

bookwar commented 3 months ago

/packit test --labels tier1

oamg / convert2rhel

[RHELC-1291, RHELC-1292] Skip versionlock file in backup system actions #1233

Codecov Report