oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
104 stars 83 forks source link

[RHELC-1556] Raise when RestorablePackage fails to restore #1234

Closed hosekadam closed 3 months ago

hosekadam commented 3 months ago

Raise exception when RestorablePackage cannot access the backup folder or the installation of the backed up packages fails.

Jira Issues:

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.44%. Comparing base (6972848) to head (1625dea). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1234 +/- ## ======================================= Coverage 95.44% 95.44% ======================================= Files 54 54 Lines 4723 4723 Branches 834 834 ======================================= Hits 4508 4508 Misses 132 132 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1234/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `90.59% <100.00%> (ø)` | | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.53% <100.00%> (ø)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.59% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kokesak commented 3 months ago

/packit build

kokesak commented 3 months ago

Tried running the tests for the rollback and now when the package installation fails during rollback it is not reported as a CRITICAL: C7 http://artifacts.osci.redhat.com/testing-farm/574bd8e5-215e-4491-93bb-e7a5abcd3beb C8 http://artifacts.osci.redhat.com/testing-farm/6b9d2432-5b52-4830-b3eb-c190d7653ab5 OL7 http://artifacts.osci.redhat.com/testing-farm/ed332fb5-6194-4d5d-98a9-399e8d0d84f4 I'm ok with merging this

has-bot commented 3 months ago

/packit test --labels sanity


Comment generated by an automation.

Log | Bot Usage