oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
104 stars 83 forks source link

[RHELC-1561] Change result of the c2r version check to OVERRIDABLE #1238

Closed bocekm closed 3 months ago

bocekm commented 3 months ago

When a newer convert2rhel version was detected, the check result was set to ERROR however we allow overriding the check by setting the CONVERT2RHEL_ALLOW_OLDER_VERSION=1 enironment variable meaning that the result is supposed to be OVERRIDABLE.

Jira Issues:

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.54%. Comparing base (972f6b6) to head (479df9c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1238 +/- ## ======================================= Coverage 95.54% 95.54% ======================================= Files 54 54 Lines 4715 4715 Branches 829 829 ======================================= Hits 4505 4505 Misses 127 127 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1238/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `90.68% <ø> (ø)` | | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.62% <ø> (ø)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.68% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 3 months ago

/packit test --labels sanity


Comment generated by an automation.

Log | Bot Usage
bookwar commented 3 months ago

/packit test --labels sanity