oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
104 stars 83 forks source link

[RHELC-1329] Port pkghandler.preserve_only_rhel_kernel() to Action framework #1250

Closed pr-watson closed 1 month ago

pr-watson commented 3 months ago

This PR ports the function preserve_only_rhel_kernel to the action framework. Changing any relevant logger crictical, warning and info messages to Error results and Warning and Info messages respectively.

Jira Issues:

Checklist

pr-watson commented 3 months ago

@r0x0d will add the tests after we confirm that this structure is okay for the port

has-bot commented 3 months ago

/packit test --labels sanity


Comment generated by an automation.

Log | Bot Usage
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.41379% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.13%. Comparing base (703e2b3) to head (d39ebc4).

Files Patch % Lines
...el/actions/conversion/preserve_only_rhel_kernel.py 97.41% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1250 +/- ## ========================================== + Coverage 95.92% 96.13% +0.21% ========================================== Files 56 57 +1 Lines 4784 4818 +34 Branches 750 846 +96 ========================================== + Hits 4589 4632 +43 + Misses 111 107 -4 + Partials 84 79 -5 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.39% <97.41%> (+0.25%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.31% <97.41%> (?)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.35% <97.41%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pr-watson commented 2 months ago

/packit build

r0x0d commented 1 month ago

/packit build

r0x0d commented 1 month ago

/packit test --labels sanity