oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

[RHELC-1331] Port post_ponr_set_efi_configuration() to Action framework #1256

Open pr-watson opened 2 months ago

pr-watson commented 2 months ago

This PR ports the post_ponr_set_efi_configuration function to the action framework. Changing any relevant logger crictical, warning and info messages to Error results and Warning and Info messages respectively.

Jira Issues:

Checklist

has-bot commented 2 months ago

/packit test --labels sanity


Comment generated by an automation.

Log | Bot Usage
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base (3b5eb16) to head (84b3f58).

Files Patch % Lines
convert2rhel/actions/conversion/set_efi_config.py 91.13% 4 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1256 +/- ## ========================================== - Coverage 95.83% 95.81% -0.03% ========================================== Files 55 56 +1 Lines 4756 4778 +22 Branches 836 841 +5 ========================================== + Hits 4558 4578 +20 - Misses 112 113 +1 - Partials 86 87 +1 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1256/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.04% <91.25%> (+0.02%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.95% <91.25%> (-0.01%)` | :arrow_down: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.99% <91.25%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.