[RHELC-1554] Remove RHSM repositories enablement fallback

r0x0d commented 1 month ago

In case of repositories not being able to be enabled, we won't fallback to the normal RHSM repoids anymore. Instead, we want to throw an error and tell the user what was the reason on why we couldn't enable the repository.

This simplify the function that handles the enablement, making it much more simpler now.

Jira Issues:

RHELC-1554

Checklist

[ ] PR has been tested manually in a VM (either author or reviewer)
[ ] Jira issue has been made public if possible
[ ] [RHELC-] or [HMS-] is part of the PR title
[ ] GitHub label has been added to help with Release notes
[ ] PR title explains the change from the user's point of view
[ ] Code and tests are documented properly
[ ] The commits are squashed to as few commits as possible (without losing data)
[ ] When merged: Jira issue has been updated to Release Pending if relevant

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (3b5eb16) to head (9a185bd).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1258 +/- ## ========================================== - Coverage 95.83% 95.83% -0.01% ========================================== Files 55 55 Lines 4756 4749 -7 Branches 836 834 -2 ========================================== - Hits 4558 4551 -7 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.01% <100.00%> (-0.02%)` | :arrow_down: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.94% <100.00%> (-0.02%)` | :arrow_down: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.99% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.