oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

Remove leftover analysis environment variable #1260

Closed r0x0d closed 1 month ago

r0x0d commented 1 month ago

In the past, we introduced this environment variable to enable analysis when it was in tech preview. Since we are not in that stage anymore, the variable was left behind in the code after we started to remove all tech preview code.

Jira Issues:

-

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.85%. Comparing base (e24afa5) to head (c16e630). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1260 +/- ## ========================================== + Coverage 95.74% 95.85% +0.10% ========================================== Files 55 55 Lines 4752 4747 -5 Branches 834 832 -2 ========================================== Hits 4550 4550 + Misses 116 112 -4 + Partials 86 85 -1 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1260/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1260/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.02% <100.00%> (+0.09%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1260/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.96% <100.00%> (+0.09%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1260/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.00% <100.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 1 month ago

/packit test --labels tier0


Comment generated by an automation.

Log | Bot Usage
Venefilyn commented 1 month ago

The test failures seem unrelated, but want a second pair of eyes. @oamg/conversions-qe ideally one of you so you can see if there is new issues we should document somewhere

kokesak commented 1 month ago

The test failures seem unrelated, but want a second pair of eyes. @oamg/conversions-qe ideally one of you so you can see if there is new issues we should document somewhere

Yes it seems that there are unrelated errors like

>           assert False, "Unknown destination distro '%s'" % destination_distro
E           AssertionError: Unknown destination distro 'Red Hat Enterprise Linux release 8.10 (Ootpa)

and custom repos tests failures which should be now fixed under the https://github.com/oamg/convert2rhel/pull/1244 (which we just merged).

@Venefilyn, @r0x0d feel free to merge it