oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

[RHELC-1334] Port ModifiedRPMFilesDiff to Action framework #1266

Open hosekadam opened 1 month ago

hosekadam commented 1 month ago

This new action provides information about difference between 'rpm -Va' from before and after the conversion.

Durign this port was needed to change the logging in the SystemInfo class to use global provided logging instead of the one inside of the class. Which was overall the same, just created dependency for logging to be inside of the class, or in the systeminfo.py would be duplicity for logging.

Jira Issues:

-RHELC-1334

Checklist

hosekadam commented 1 month ago

Applied the changes - no big changes to the systeminfo, porting (better say writing new) unit tests. Still WIP, will continue after PTO

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.92%. Comparing base (81c59f6) to head (7cd5724).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1266 +/- ## ========================================== + Coverage 95.84% 95.92% +0.07% ========================================== Files 55 56 +1 Lines 4771 4784 +13 Branches 840 841 +1 ========================================== + Hits 4573 4589 +16 + Misses 112 111 -1 + Partials 86 84 -2 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1266/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.14% <100.00%> (+0.08%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.06% <100.00%> (+0.08%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.11% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 1 week ago

/packit test --labels sanity


Comment generated by an automation.

Log | Bot Usage