search

oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

[2.0.0] option --no-rpm-va is irgnored #1268

Closed mdc-webdb closed 1 month ago

mdc-webdb commented 1 month ago

Call: convert2rhel analyze --no-rpm-va result in:

Running the 'rpm -Va' command which can take several minutes. It can be disabled by using the --no-rpm-va option. [2024-06-19T06:38:09+0000] DEBUG - Calling command 'rpm -Va' The 'rpm -Va' output has been stored in the /var/log/convert2rhel/rpm_va.log file.

hosekadam commented 1 month ago

Hello! Thanks for reaching us!

The --no-rpm-va requires setting the CONVERT2RHEL_INCOMPLETE_ROLLBACK environment variable since version 1.6.0, where the output of the command is needed for complete backup (backup of changed RPM files).

If the CONVERT2RHEL_INCOMPLETE_ROLLBACK is not set, the --no-rpm-va is ignored - this fact is also mentioned in the log (before the EULA). I understand you could miss the information, I will discuss with the team if we should move the warning somewhere after the EULA to be more visible.

mdc-webdb commented 1 month ago

This will be a good idea. Or output an warning, that the option is ignored, during the missing environment variable.

hosekadam commented 1 month ago

The warning is printed (WARNING - We will proceed with ignoring the --no-rpm-va option as running rpm -Va in the analysis mode is essential for a complete rollback to the original system state at the end of the analysis.), but before the EULA (after printing the used command), which is a big piece of text, it fills your screen and makes the warning invisible.

r0x0d commented 1 month ago

The warning is printed (WARNING - We will proceed with ignoring the --no-rpm-va option as running rpm -Va in the analysis mode is essential for a complete rollback to the original system state at the end of the analysis.), but before the EULA (after printing the used command), which is a big piece of text, it fills your screen and makes the warning invisible.

Maybe we could open an issue to move those warnings to happen after the EULA, or we could experiment some other options as well.