oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

chore: improve sphinx workflow with composite action #1274

Closed Venefilyn closed 1 month ago

Venefilyn commented 1 month ago

This changes the Sphinx GitHub action to use a composite action that does not install Sphinx on its own, but rather takes care of comments so that we can more easily run everything as we want

We also add packages using apt instead of pip, as we otherwise ran into some weird issues. But I've tested on my branch and works fine

See https://venefilyn.github.io/convert2rhel

Jira Issues:

-

Checklist

has-bot commented 1 month ago

This PR does not require integration tests to be run.


Comment generated by an automation.

Log | Bot Usage
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (3c8e4a3) to head (81f2d89).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1274 +/- ## ======================================= Coverage 95.83% 95.83% ======================================= Files 55 55 Lines 4756 4756 Branches 836 836 ======================================= Hits 4558 4558 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1274/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.02% <ø> (ø)` | | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.95% <ø> (ø)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.