oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

[RHELC-961] Rename fingerprint to key_id #1280

Open r0x0d opened 1 month ago

r0x0d commented 1 month ago

Across the entire codebase, we are renaming from fingerprint to key_id to maintain consistency throught the entire code base and the tools we use.

This patch introduces the renaming of that key ranging from code to config files.

Jira Issues:

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.83%. Comparing base (3b5eb16) to head (fbfeb87).

Files Patch % Lines
convert2rhel/pkghandler.py 95.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1280 +/- ## ======================================= Coverage 95.83% 95.83% ======================================= Files 55 55 Lines 4756 4756 Branches 836 836 ======================================= Hits 4558 4558 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1280/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1280/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.02% <96.42%> (ø)` | | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1280/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.95% <96.42%> (ø)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1280/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.00% <96.42%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.