oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

Skip tmt checks if not tests file #1284

Closed r0x0d closed 1 month ago

r0x0d commented 1 month ago

Skipping the hook to run on all files/folders, only execute it in tests folder

Jira Issues:

-

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (fc397d1) to head (1a8484a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1284 +/- ## ======================================= Coverage 95.83% 95.83% ======================================= Files 55 55 Lines 4756 4756 Branches 836 836 ======================================= Hits 4558 4558 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.02% <ø> (ø)` | | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.95% <ø> (ø)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 1 month ago

This PR does not require integration tests to be run.


Comment generated by an automation.

Log | Bot Usage
kokesak commented 1 month ago

from the "pre-commit.ci" check:

==> File .pre-commit-config.yaml
==> At Config()
==> At key: repos
==> At Repository(repo='https://github.com/teemtee/tmt.git')
==> At key: hooks
==> At Hook(id='tmt-tests-lint')
==> At key: files
=====> Expected string got list

It seems that it doesn't like list for some reason :( I haven't found much about that linter beside this https://tmt.readthedocs.io/en/stable/guide.html#lint. Do you know more about that @r0x0d ?

r0x0d commented 1 month ago

from the "pre-commit.ci" check:

==> File .pre-commit-config.yaml
==> At Config()
==> At key: repos
==> At Repository(repo='https://github.com/teemtee/tmt.git')
==> At key: hooks
==> At Hook(id='tmt-tests-lint')
==> At key: files
=====> Expected string got list

It seems that it doesn't like list for some reason :( I haven't found much about that linter beside this https://tmt.readthedocs.io/en/stable/guide.html#lint. Do you know more about that @r0x0d ?

Ah, yeah. This is a problem with pre-commit. Let me fix it.

r0x0d commented 1 month ago

from the "pre-commit.ci" check:

==> File .pre-commit-config.yaml
==> At Config()
==> At key: repos
==> At Repository(repo='https://github.com/teemtee/tmt.git')
==> At key: hooks
==> At Hook(id='tmt-tests-lint')
==> At key: files
=====> Expected string got list

It seems that it doesn't like list for some reason :( I haven't found much about that linter beside this https://tmt.readthedocs.io/en/stable/guide.html#lint. Do you know more about that @r0x0d ?

Okay, fixed it!