oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

[RHELC-1606] Fix duplicating backups #1287

Closed Venefilyn closed 1 week ago

Venefilyn commented 1 month ago

It was possible for multiple packages to depend on the same file. As we fetch the files for each package that needs to be backed up this caused issues when rolling back a system as we try to restore it twice.

This fixes that issue by making sure we don't backup to the same path multiple times

Jira Issues:

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.84%. Comparing base (a69b222) to head (b03d3cc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1287 +/- ## ========================================== + Coverage 95.83% 95.84% +0.01% ========================================== Files 55 55 Lines 4756 4768 +12 Branches 836 839 +3 ========================================== + Hits 4558 4570 +12 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1287/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.04% <100.00%> (+0.02%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.97% <100.00%> (+0.02%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.02% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 1 month ago

/packit test --labels tier0


Comment generated by an automation.

Log | Bot Usage
Venefilyn commented 1 month ago

/packit test --labels tier0

Venefilyn commented 3 weeks ago

/packit test --labels tier0

Venefilyn commented 3 weeks ago

/packit test --labels tier0

Venefilyn commented 2 weeks ago

/packit test --labels tier0