oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

Use enablerepo instead of no_rhsm to check custom repos #1288

Open r0x0d opened 1 month ago

r0x0d commented 1 month ago

We were using the no_rhsm option to skip the check for custom repositories, and since the system can be unregistered or pre-registered, there is no need anymore to use no_rhsm in this action, instead, we can use enablerepo directly to validate if the repositories are valid or not.

Jira Issues:

-

Checklist


TODO

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (5c42c1f) to head (bcdb1b0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1288 +/- ## ======================================= Coverage 95.83% 95.83% ======================================= Files 55 55 Lines 4756 4757 +1 Branches 836 836 ======================================= + Hits 4558 4559 +1 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.02% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.95% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.00% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.