oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

[RHELC-1626] Use no_rhsm to detect if enablerepos should be disabled #1289

Closed r0x0d closed 1 week ago

r0x0d commented 1 month ago

We have a special function that returns a list of repositories that needs to be disabled during various command calls, and that list is returning always the user enablerepos command line switch in it. This patch only add the enablerepos option to the list when the --no-rhsm switch is also applied.

Jira Issues:

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.84%. Comparing base (794568c) to head (16d354e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1289 +/- ## ======================================= Coverage 95.84% 95.84% ======================================= Files 55 55 Lines 4768 4771 +3 Branches 839 840 +1 ======================================= + Hits 4570 4573 +3 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.05% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.98% <100.00%> (+<0.01%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.02% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

has-bot commented 1 month ago

/packit test --labels tier0


Comment generated by an automation.

Log | Bot Usage
r0x0d commented 1 month ago

/packit test --labels tier0

Comment generated by an automation. Log | Bot Usage

Added tier0 label based on finding a test that uses custom repositories that is in the tier0 folder

bookwar commented 3 weeks ago

/packit test --labels tier0

bookwar commented 3 weeks ago

/packit test --labels tier0

bookwar commented 3 weeks ago

/packit test --labels tier0

r0x0d commented 3 weeks ago

/packit test --labels tier0

hosekadam commented 3 weeks ago

Couldn't test (outage of the Candlepin), but the changes look good.

r0x0d commented 3 weeks ago

/packit test --labels tier0

r0x0d commented 3 weeks ago

/packit test --labels tier0

Venefilyn commented 1 week ago

/packit test --labels tier0