oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
103 stars 82 forks source link

[RHELC-1635] State action in special pkg removal report msgs #1297

Open bocekm opened 3 weeks ago

bocekm commented 3 weeks ago

Customers have been confused when seeing the messages, not knowing what should they do.

Jira Issues:

Checklist

has-bot commented 3 weeks ago

/packit test --labels sanity


Comment generated by an automation.

Log | Bot Usage
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (52054d3) to head (2e5ac98).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1297 +/- ## ======================================= Coverage 95.83% 95.83% ======================================= Files 55 55 Lines 4756 4756 Branches 836 836 ======================================= Hits 4558 4558 Misses 112 112 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1297/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1297/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.02% <100.00%> (ø)` | | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1297/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.95% <100.00%> (ø)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1297/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bocekm commented 3 weeks ago

@pr-watson, I've reworded the messages a bit. Please take a look.

EDIT: I can imagine a couple of ways to improve the messages even further - I've laid the ideas out at https://issues.redhat.com/browse/RHELC-1637. They can be worked on in another PR.