[RHELC-1332] Port PkgManagerConf() to the Action framework

pr-watson commented 3 months ago

This PR calls the PkgManagerConf class inside a new action called pkg_manager_config so it can be executed alongside the other actions in the conversion section. Relevant tests have been written.

Jira Issues:

RHELC-1332

Checklist

[x] PR has been tested manually in a VM (either author or reviewer)
[x] Jira issue has been made public if possible
[x] [RHELC-] or [HMS-] is part of the PR title
[x] GitHub label has been added to help with Release notes
[x] PR title explains the change from the user's point of view
[x] Code and tests are documented properly
[x] The commits are squashed to as few commits as possible (without losing data)
[ ] When merged: Jira issue has been updated to Release Pending if relevant

has-bot commented 3 months ago

/packit test --labels sanity

Comment generated by an automation.

Log | Bot Usage

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.35%. Comparing base (80333d9) to head (c0b3908). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1321 +/- ## ========================================== + Coverage 96.30% 96.35% +0.05% ========================================== Files 59 60 +1 Lines 4872 4884 +12 Branches 858 860 +2 ========================================== + Hits 4692 4706 +14 + Misses 103 101 -2 Partials 77 77 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1321/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1321/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.67% <100.00%> (+0.06%)` | :arrow_up: | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1321/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.58% <100.00%> (+0.06%)` | :arrow_up: | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1321/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.62% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pr-watson commented 3 months ago

Looks good to me.

The only thing is that the action looks confusing right now, as the name of the class is almost the name of what we call underneath it. The only main difference in the naming is the ig at the name of the action class 🤔

Is there a way we can improve it somehow?

Looks good to me.

The only thing is that the action looks confusing right now, as the name of the class is almost the name of what we call underneath it. The only main difference in the naming is the ig at the name of the action class 🤔

Is there a way we can improve it somehow?

@r0x0d I could extend the name of the action class to PackageManagerConfiguration or maybe ConfigurePkgManager