oamg / convert2rhel

A tool to automate converting Oracle/CentOS/Scientific/Rocky/Alma Linux to Red Hat Enterprise Linux
GNU General Public License v3.0
104 stars 84 forks source link

hotfix/Fix backup_directory test fixture #1362

Closed danmyway closed 2 months ago

danmyway commented 2 months ago
has-bot commented 2 months ago

This PR does not require integration tests to be run.


Comment generated by an automation.

Log | Bot Usage
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.43%. Comparing base (954dbe2) to head (81b0495). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1362 +/- ## ======================================= Coverage 96.43% 96.43% ======================================= Files 66 66 Lines 4997 4997 Branches 877 877 ======================================= Hits 4819 4819 Misses 101 101 Partials 77 77 ``` | [Flag](https://app.codecov.io/gh/oamg/convert2rhel/pull/1362/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | Coverage Δ | | |---|---|---| | [centos-linux-7](https://app.codecov.io/gh/oamg/convert2rhel/pull/1362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `91.86% <ø> (ø)` | | | [centos-linux-8](https://app.codecov.io/gh/oamg/convert2rhel/pull/1362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.75% <ø> (ø)` | | | [centos-linux-9](https://app.codecov.io/gh/oamg/convert2rhel/pull/1362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg) | `92.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oamg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danmyway commented 2 months ago

Tests passing (and running now), won't trigger the whole suite just for that.

+--------------------------------------+-----------------------------------------+-----------------------------------+--------------------------------------------------------------+--------+
| UUID                                 | Target                                  | Test Plan                         | Test Case                                                    | Result |
+--------------------------------------+-----------------------------------------+-----------------------------------+--------------------------------------------------------------+--------+
| 42ea0c3a-f3ab-4b26-905c-f8c2bfcf396c | CentOS-Stream-8                         |                                   |                                                              |        |
|                                      |                                         | plans/stream/core/non-destructive |                                                              | PASSED |
|                                      |                                         |                                   | tests/integration/tier0/non-destructive/kernel/custom_kernel | PASSED |
| 0cd6ae52-14c9-47f0-931a-1f29e040d6b4 | OL7.9-x86_64-HVM-2023-01-05             |                                   |                                                              |        |
|                                      |                                         | plans/tier0/core/non-destructive  |                                                              | PASSED |
|                                      |                                         |                                   | tests/integration/tier0/non-destructive/kernel/custom_kernel | PASSED |
| 70d51da7-af6c-4d3e-82f6-f6e8b97f9ac7 | Rocky-8-EC2-Base-8.10-20240528.0.x86_64 |                                   |                                                              |        |
|                                      |                                         | plans/tier0/core/non-destructive  |                                                              | PASSED |
|                                      |                                         |                                   | tests/integration/tier0/non-destructive/kernel/custom_kernel | PASSED |
| c5a396e7-3369-444c-96d7-7654c7bd788e | OL8.9-x86_64-HVM-2024-02-02             |                                   |                                                              |        |
|                                      |                                         | plans/tier0/core/non-destructive  |                                                              | PASSED |
|                                      |                                         |                                   | tests/integration/tier0/non-destructive/kernel/custom_kernel | PASSED |
| f7b51f98-d34b-4332-99fc-cb4b396caad2 | Rocky-8-EC2-Base-8.8-20230518.0.x86_64  |                                   |                                                              |        |
|                                      |                                         | plans/tier0/core/non-destructive  |                                                              | PASSED |
|                                      |                                         |                                   | tests/integration/tier0/non-destructive/kernel/custom_kernel | PASSED |
| bd286a00-58d6-4c4f-9fb3-d9e17b854bb8 | AlmaLinux OS 8.10.20240820 x86_64       |                                   |                                                              |        |
|                                      |                                         | plans/tier0/core/non-destructive  |                                                              | PASSED |
|                                      |                                         |                                   | tests/integration/tier0/non-destructive/kernel/custom_kernel | PASSED |
| 5fc62e20-bc04-48c5-bc39-5ba7fe67651d | AlmaLinux OS 8.8.20230524 x86_64        |                                   |                                                              |        |
|                                      |                                         | plans/tier0/core/non-destructive  |                                                              | PASSED |
|                                      |                                         |                                   | tests/integration/tier0/non-destructive/kernel/custom_kernel | PASSED |
+--------------------------------------+-----------------------------------------+-----------------------------------+--------------------------------------------------------------+--------+