oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

be less strict when figuring out major version in initrd #1140

Closed evgeni closed 10 months ago

evgeni commented 10 months ago

We only care for the major part of the version, so it's sufficient to grep without the dot, which is not present on CentOS initrd.

CentOS Stream 8:

VERSION="8 dracut-049-224.git20230330.el8"
VERSION_ID=049-224.git20230330.el8

CentOS Stream 9:

VERSION="9 dracut-057-38.git20230725.el9"
VERSION_ID="9"

RHEL 8.8:

VERSION="8.8 (Ootpa) dracut-049-223.git20230119.el8"
VERSION_ID=049-223.git20230119.el8

RHEL 9.2:

VERSION="9.2 (Plow) dracut-057-21.git20230214.el9"
VERSION_ID="9.2"

Ideally, we would just use the major part of VERSION_ID, but this is set to the underlying OS'es VERSION_ID only since dracut 050 [1] and EL8 ships with 049.

[1] https://github.com/dracutdevs/dracut/commit/72ae1c4fe73c5637eb8f6843b9a127a6d69469d6

github-actions[bot] commented 10 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

fernflower commented 10 months ago

I guess it's good to go. Thanks for the contribution!