Introduce the checkmptctl actor

bessonc commented 10 months ago

Raise an inhibitor if the mptctl is loaded and in use, and reports the userspace processes which use it. The suggested patch is not ideal and could be refactored as it adds another inhibitor for the same problem reported by the CheckDetectedDevicesAndDrivers actor. This is essentially to share the logic in pure python, without any additional requirement.

Fixes Red Hat issue #RHEL-15894

Outputs:

Upgrade has been inhibited due to the following problems:
    1. Inhibitor: Leapp detected loaded kernel drivers which have been removed in RHEL 8. Upgrade cannot proceed.
    2. Inhibitor: Detected processes that are using mptctl.
Consult the pre-upgrade report for details and possible remediation.

----------------------------------------
Risk Factor: high (inhibitor)
Title: Detected processes that are using mptctl.
Summary: Leapp detected that the following processes are using the mptctl kernel module which will be removed in RHEL 8:
20914: python -c f=open('/dev/mptctl','r');import time;time.sleep(300) 
14348: python -c f=open('/dev/mptctl','r');import time;time.sleep(300) 
Remediation: [hint] Stop this application or the service that runs this process.
Key: 66e1a0da39c67d3495587ed2d1bd8e810e41288d
----------------------------------------

github-actions[bot] commented 10 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

review please @oamg/developers to notify leapp developers of the review request
/packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

/packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
/packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

/rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
/rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
/rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
/rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

mkluson commented 10 months ago

Hi there, as we agreed in the bug (https://issues.redhat.com/browse/RHEL-15894) this issue will be addressed by KCS. Closing this PR

oamg / leapp-repository

Introduce the checkmptctl actor #1141

Thank you for contributing to the Leapp project!