oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
52 stars 146 forks source link

pes_events_scanner: Ignore Leapp related PES events #1153

Closed matejmatuska closed 9 months ago

matejmatuska commented 11 months ago

When PES events are added for all the Leapp related packages, we need to make sure to ignore them in pes_events_scanner to make sure they are not taken into account during the RPM upgrade transaction as we don't want to upgrade them or want to handle their upgrade in a different way.

Jira: OAMG-5645

github-actions[bot] commented 11 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

fernflower commented 10 months ago

Rebase against master should solve test failures

pirat89 commented 9 months ago

Done some manual testing on RHEL 7 (skipping testing on RHEL 8 now):

# leapp preupgrade --debug --no-rhsm
....
2024-01-12 11:50:58.866 DEBUG    PID: 32559 leapp.workflow.FactsCollection.pes_events_scanner: Filtered out leapp related event, event id: 50000
2024-01-12 11:50:58.867 DEBUG    PID: 32559 leapp.workflow.FactsCollection.pes_events_scanner: Filtered out leapp related event, event id: 50001
2024-01-12 11:50:58.868 DEBUG    PID: 32559 leapp.workflow.FactsCollection.pes_events_scanner: Filtered out leapp related event, event id: 50002
...

Modification in pes-event.json file:

{
    "action": 1, "id": 50000, "architectures": ["x86_64", "aarch64", "ppc64le", "s390x"],
    "in_packageset": {
        "package": [{
            "name": "leapp",
            "repository": "rhel7-extras",
            "modulestreams": [null]
        }],
        "set_id": 12
    },
    "initial_release": {
        "major_version": 7,
        "minor_version": 7,
        "os_name": "RHEL", "tag": null, "z_stream": null
    },
    "modulestream_maps": [],
    "out_packageset": null,
    "release": {
        "major_version": 8,
        "minor_version": 0,
        "os_name": "RHEL", "tag": null, "z_stream": null
    }
},

{
    "action": 3, "id": 50001,
    "architectures": ["x86_64", "aarch64", "ppc64le", "s390x"],
    "in_packageset": {
        "package": [{
            "name": "python2-leapp",
            "repository": "rhel7-extras",
            "modulestreams": [null]
        }],
        "set_id": 17
    },
    "initial_release": {
        "major_version": 7,
        "minor_version": 9,
        "os_name": "RHEL", "tag": null, "z_stream": null
    },
    "modulestream_maps": [{"in_modulestream": null, "out_modulestream": null}],
    "out_packageset": {
        "package": [{
            "name": "python3-leapp",
            "repository": "rhel8-AppStream",
            "modulestreams": [null]
        }],
        "set_id": 18
    },
    "release": {
        "major_version": 8,
        "minor_version": 6,
        "os_name": "RHEL", "tag": null, "z_stream": null
    }
},

{
    "action": 3, "id": 50002,
    "architectures": ["x86_64", "aarch64", "ppc64le", "s390x"],
    "in_packageset": {
        "package": [{
            "name": "leapp-upgrade-el7toel8",
            "repository": "rhel7-extras",
            "modulestreams": [null]
        }],
        "set_id": 17
    },
    "initial_release": {
        "major_version": 7,
        "minor_version": 9,
        "os_name": "RHEL", "tag": null, "z_stream": null
    },
    "modulestream_maps": [{"in_modulestream": null, "out_modulestream": null}],
    "out_packageset": {
        "package": [{
            "name": "leapp-upgrade-el8toel9",
            "repository": "rhel8-AppStream",
            "modulestreams": [null]
        }],
        "set_id": 18
    },
    "release": {
        "major_version": 8,
        "minor_version": 6,
        "os_name": "RHEL", "tag": null, "z_stream": null
    }
},