oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

[WIP] Fix _copy_decouple() for relative symlinks #1158

Closed abadger closed 8 months ago

abadger commented 8 months ago

It was found in testing that absolute symlinks in /etc/pki are being preserved correctly but relative symlinks are causing a traceback. This PR will fix that.

Right now this is just additional unittests for the desired behaviour:

If anyone has additional scenarios that they think should work feel free to add to the PR or mention them to me and I'll make a test for it.

github-actions[bot] commented 8 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

abadger commented 8 months ago

I pushed the branch to oamg/leapp-repository by mistake (instead of abadger/leapp-repository). Closing this in favor of: https://github.com/oamg/leapp-repository/pull/1160