oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
52 stars 146 forks source link

Make the reboot required text more visible in the console output #1173

Closed matejmatuska closed 6 months ago

matejmatuska commented 9 months ago

The "A reboot is required to continue. Please reboot your system." message is printed before the reports summary and thus is easily overlooked by users.

This patch adds a second such message after the report summary to improve this.

Example (slightly outdated, the extra comma is already removed): image

Jira: RHEL-22736

github-actions[bot] commented 9 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

matejmatuska commented 9 months ago

The exact message/wording is up for discussion of course, but I think it should also mention that the reboot can/will take more time than normal reboot. The text could also be bold/colored, but that might be too much in my opinion.

pirat89 commented 9 months ago

@matejmatuska add please jira ticket number to the commit msg and PR description.

fernflower commented 8 months ago

Rebase against master should fix the tests