oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

Packit: Drop tests for obsoleted upgrade paths + restructuralisation #1176

Closed pirat89 closed 6 months ago

pirat89 commented 7 months ago

Dropping upgrade paths related to following releases: 8.6, 8.9, 9.0, 9.3. See the previous commit for more info.

During the drop of these release, I've realized the current structure of tests is not suitable for such operations as current test/job definitions has been chained. So e.g. tests for 8.10 -> 9.4 depended on 8.9 -> 9.3, which depended on 8.8 -> 8.6, etc... Even going deeper, IPU 8->9 definitions have been based on 7 -> 8 definitions.

So I updated the structure, separating tests for IPU 7 -> 8 and 8 -> 9 and also deps between all upgrade paths. Now, particular tests can inherit one of abstract jobs definitions, so dropping or removing tests for an upgrade path does not affect other tests.

Also fixed some incorrect definitions in tests, like a fixed label for beaker-minimal-88to92 (orig "8.6to9.2").

Update welcome-PR bot msg to reflect changes in upgrade paths.

Jira: OAMG-10451

packit-as-a-service[bot] commented 7 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {3: {'trigger': ['Missing data for required field.']}, 4: {'trigger': ['Missing data for required field.']}, 5: {'trigger': ['Missing data for required field.']}, 6: {'trigger': ['Missing data for required field.']}, 9: {'trigger': ['Missing data for required field.']}, 10: {'trigger': ['Missing data for required field.']}, 12: {'trigger': ['Missing data for required field.']}, 13: {'trigger': ['Missing data for required field.']}, 14: {'trigger': ['Missing data for required field.']}, 15: {'trigger': ['Missing data for required field.']}, 16: {'trigger': ['Missing data for required field.']}, 17: {'trigger': ['Missing data for required field.']}, 18: {'trigger': ['Missing data for required field.']}, 19: {'trigger': ['Missing data for required field.']}, 20: {'trigger': ['Missing data for required field.']}, 21: {'trigger': ['Missing data for required field.']}, 22: {'trigger': ['Missing data for required field.']}, 23: {'trigger': ['Missing data for required field.']}, 24: {'trigger': ['Missing data for required field.']}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 7 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {3: {'trigger': ['Missing data for required field.']}, 4: {'trigger': ['Missing data for required field.']}, 5: {'trigger': ['Missing data for required field.']}, 6: {'trigger': ['Missing data for required field.']}, 9: {'trigger': ['Missing data for required field.']}, 10: {'trigger': ['Missing data for required field.']}, 12: {'trigger': ['Missing data for required field.']}, 13: {'trigger': ['Missing data for required field.']}, 14: {'trigger': ['Missing data for required field.']}, 15: {'trigger': ['Missing data for required field.']}, 16: {'trigger': ['Missing data for required field.']}, 17: {'trigger': ['Missing data for required field.']}, 18: {'trigger': ['Missing data for required field.']}, 19: {'trigger': ['Missing data for required field.']}, 20: {'trigger': ['Missing data for required field.']}, 21: {'trigger': ['Missing data for required field.']}, 22: {'trigger': ['Missing data for required field.']}, 23: {'trigger': ['Missing data for required field.']}, 24: {'trigger': ['Missing data for required field.']}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 7 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {3: {'trigger': ['Missing data for required field.']}, 4: {'trigger': ['Missing data for required field.']}, 5: {'trigger': ['Missing data for required field.']}, 6: {'trigger': ['Missing data for required field.']}, 9: {'trigger': ['Missing data for required field.']}, 10: {'trigger': ['Missing data for required field.']}, 12: {'trigger': ['Missing data for required field.']}, 13: {'trigger': ['Missing data for required field.']}, 14: {'trigger': ['Missing data for required field.']}, 15: {'trigger': ['Missing data for required field.']}, 16: {'trigger': ['Missing data for required field.']}, 17: {'trigger': ['Missing data for required field.']}, 18: {'trigger': ['Missing data for required field.']}, 19: {'trigger': ['Missing data for required field.']}, 20: {'trigger': ['Missing data for required field.']}, 21: {'trigger': ['Missing data for required field.']}, 22: {'trigger': ['Missing data for required field.']}, 23: {'trigger': ['Missing data for required field.']}, 24: {'trigger': ['Missing data for required field.']}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

github-actions[bot] commented 7 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

pirat89 commented 7 months ago

@oamg/developers blocked by https://github.com/packit/packit/issues/2231. Discussed with @lbarcziova, we will wait for the Packit decision around this functionality. Most likely, it will need still some changes, but waiting with them until we know whether & how this will be implemented in Packit.

pirat89 commented 7 months ago

/packit test

packit-as-a-service[bot] commented 7 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {3: {'trigger': ['Missing data for required field.']}, 4: {'trigger': ['Missing data for required field.']}, 5: {'trigger': ['Missing data for required field.']}, 6: {'trigger': ['Missing data for required field.']}, 9: {'trigger': ['Missing data for required field.']}, 10: {'trigger': ['Missing data for required field.']}, 12: {'trigger': ['Missing data for required field.']}, 13: {'trigger': ['Missing data for required field.']}, 14: {'trigger': ['Missing data for required field.']}, 15: {'trigger': ['Missing data for required field.']}, 16: {'trigger': ['Missing data for required field.']}, 17: {'trigger': ['Missing data for required field.']}, 18: {'trigger': ['Missing data for required field.']}, 19: {'trigger': ['Missing data for required field.']}, 20: {'trigger': ['Missing data for required field.']}, 21: {'trigger': ['Missing data for required field.']}, 22: {'trigger': ['Missing data for required field.']}, 23: {'trigger': ['Missing data for required field.']}, 24: {'trigger': ['Missing data for required field.']}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 7 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {3: {'trigger': ['Missing data for required field.']}, 4: {'trigger': ['Missing data for required field.']}, 5: {'trigger': ['Missing data for required field.']}, 6: {'trigger': ['Missing data for required field.']}, 9: {'trigger': ['Missing data for required field.']}, 10: {'trigger': ['Missing data for required field.']}, 12: {'trigger': ['Missing data for required field.']}, 13: {'trigger': ['Missing data for required field.']}, 14: {'trigger': ['Missing data for required field.']}, 15: {'trigger': ['Missing data for required field.']}, 16: {'trigger': ['Missing data for required field.']}, 17: {'trigger': ['Missing data for required field.']}, 18: {'trigger': ['Missing data for required field.']}, 19: {'trigger': ['Missing data for required field.']}, 20: {'trigger': ['Missing data for required field.']}, 21: {'trigger': ['Missing data for required field.']}, 22: {'trigger': ['Missing data for required field.']}, 23: {'trigger': ['Missing data for required field.']}, 24: {'trigger': ['Missing data for required field.']}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 7 months ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {3: {'trigger': ['Missing data for required field.']}, 4: {'trigger': ['Missing data for required field.']}, 5: {'trigger': ['Missing data for required field.']}, 6: {'trigger': ['Missing data for required field.']}, 9: {'trigger': ['Missing data for required field.']}, 10: {'trigger': ['Missing data for required field.']}, 12: {'trigger': ['Missing data for required field.']}, 13: {'trigger': ['Missing data for required field.']}, 14: {'trigger': ['Missing data for required field.']}, 15: {'trigger': ['Missing data for required field.']}, 16: {'trigger': ['Missing data for required field.']}, 17: {'trigger': ['Missing data for required field.']}, 18: {'trigger': ['Missing data for required field.']}, 19: {'trigger': ['Missing data for required field.']}, 20: {'trigger': ['Missing data for required field.']}, 21: {'trigger': ['Missing data for required field.']}, 22: {'trigger': ['Missing data for required field.']}, 23: {'trigger': ['Missing data for required field.']}, 24: {'trigger': ['Missing data for required field.']}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

pirat89 commented 7 months ago

@oamg/developers @fernflower works now as expected. review it please and let me know if you want some changes here.

fernflower commented 7 months ago

/packit test --labels beaker-minimal-8.9to9.3,

fernflower commented 7 months ago

/packit test --labels beaker-minimal-8.9to9.3

fernflower commented 7 months ago

/packit test --labels kernel-rt-8.9to9.3

fernflower commented 7 months ago

The on-demand scheduling of tests doesn't work anymore unfortunately. Before the refactoring select tests would be rescheduled with "/packit test --labels kernel-rt-8.9to9.3" command. For example I ran it on https://github.com/oamg/leapp-repository/pull/1178 and got exactly one test rerun. image

pirat89 commented 7 months ago

@fernflower please read again the description of the PR. The results seems to me expected. 8.9 -> 9.3 is not a valid label nor upgrade path anymore. the #1178 PR is not rebased against up-to-date master, so there are still defined obsoleted upgrade paths (https://github.com/MichalHe/leapp-repository/blob/rhui_disable_bootstrap_on_aws/repos/system_upgrade/common/files/upgrade_paths.json)

fernflower commented 7 months ago

/packit test --labels beaker-minimal-8.10to9.4

fernflower commented 7 months ago

Hmm @pirat89 tried beaker-minimal-8.10to9.4 and still nothing scheduled. What am I doing wrong?

pirat89 commented 7 months ago

@fernflower seems it was just a longer queue in Packit service. I see it's in progress now:

testing-farm:RHEL-8.10.0-Nightly-x86_64:sanity-8.10to9.4-beaker-minimal-ondemand In progress — Tests have been submitted ...
fernflower commented 7 months ago

Also I see Fixed some incorrect definitions in the commit message - could you please elaborate what exactly was wrong and how it was changed?

fernflower commented 7 months ago

/packit test --labels kernel-rt-8.10to9.4

fernflower commented 7 months ago

Please also change the example of on-demand packit testing invocation in welcome bot https://github.com/oamg/leapp-repository/blob/master/.github/workflows/pr-welcome-msg.yml#L32

pirat89 commented 7 months ago

Also I see Fixed some incorrect definitions in the commit message - could you please elaborate what exactly was wrong and how it was changed?

e.g. beaker-minimal-88to92 had label 8.6to9.2. not sure whether it was only error or whether there were other, but this one I remember well.

pirat89 commented 7 months ago

Please also change the example of on-demand packit testing invocation in welcome bot https://github.com/oamg/leapp-repository/blob/master/.github/workflows/pr-welcome-msg.yml#L32

Good point! I think it's also time to drop obsoleted commands.

pirat89 commented 6 months ago

@fernflower done :)