Add unit tests for scansourcefiles actor

tomasfratrik commented 6 months ago

Test if files are correctly tracked by actor. Create mocked existent/non-existent, modified/non-modified, rpm owned/not-owned files. Also test non-existent version files.

Jira: OAMG-10367

github-actions[bot] commented 6 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

review please @oamg/developers to notify leapp developers of the review request
/packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42 Note that first time contributors cannot run tests automatically - they will be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

/packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
/packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

tomasfratrik commented 5 months ago

My notes:

I separated some values in pytest parametrize, because I think is now more readable (i can see it faster what is what, and it is not too much longer). - Now I see that testing farm won't allow me to do this, so I will fix this
I split test of function _get_rpm_name into 2 tests, 1 containing normal tests, and other one error. Now it could considered as 'redundant' (even though the code still differs), but I think it is more readable. Before there were basically multiple if statements that separated if it is error or not.
Removed one rpm test. After consideration, I realized it is not testing anything I haven't tested before
My thought process over test test_tracked_files, which tests process, was that, I will give 'you' (process function), tracked files, and major version, and you do the rest. Process should just take files from 'common' and 'major_version' but I "don't know that", so I let it do whatever it wants to, and then compare. And mainly compare produced message.

I will squash commits, and write proper commit message after approved, or when it is finalized.