search

oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

sysstat doesn't upgrade generated 7 data files correctly to 8 #1204

Open toddr opened 4 months ago

toddr commented 4 months ago

If you happen to be running the sysstat-collect service which collects data over time, the file format changes between 7 and 8. When leapp runs, it does not convert or move the old files out of the way so sar is broken until you do so manually. I'm looking for an opinion, should leapp be fixing this? Reference data: https://access.redhat.com/solutions/5240511.

Actual behavior sysstat doesn't upgrade generated 7 data files correctly to 8.

To Reproduce

On CentOS 7

  1. install sysstat RPM
  2. enable the monitoring service: systemctl enable sysstat; systemctl start sysstat
  3. Wait time for data to generate on 7...
  4. use leapp to upgrade to 8.
  5. After upgrade Run: sar and you'll see no data at all.

Expected behavior sysstat data should be upgraded or set aside when upgrading to 8 so it will at the least begin collecting new data if not appending to the previous data from 7.

Additional context Upgrade information on the data files is mentioned here: https://access.redhat.com/solutions/5240511.

You can also fix this by doing: rm /var/log/sa/sa* during the leapp upgrade though this leads to data loss.

pirat89 commented 4 months ago

Hi @toddr, it would have been handled during the upgrade, but due some unlucky circumstances, it has been deferred. The right place is either sysstat rpm scriptlet or leapp-repository. Right now, most likely it will stay as unfixed issue, as we are ending slowly with our work on IPU 7 -> 8 and we are investing our capacity on IPU 8 -> 9 and newer upgrade paths. Cannot say how it will be for sure :shrug: I am try to be realistic. Fix seems easy, so it could be still implemented by community in upstream, but no idea whether it will be delivered in RHEL 7 anyway. RHEL ticket:

Most realistic possibility is that we document this as known issue or post-upgrade step in the official upgrade docs.

toddr commented 4 months ago

Thank you. We'll likely just work around the issue for elevate-cpanel customers.